fixed support of multiple objects for same predicate#22
Merged
Conversation
mcollina
added a commit
that referenced
this pull request
Mar 1, 2014
fixed support of multiple objects for same predicate
Collaborator
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar issue that we had in #19 then fixed in #21
i stumbled on this bug while working on support for multiple languages for http://unmonastery.net , made not the cleanest fix i can imagine but it works and all tests pass!
at some point 📆 i'll need to do refactoring round to tidy up few things... especially tests
@mcollina if you feel ok with merging it maybe you could release it right away as 0.3.1 ?